pointer dataflow #1630
Merged
pointer dataflow #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
requested changes
May 24, 2023
There was a problem hiding this comment.
I want to dispatch whenever the focused index changes (on render when i !== ii) rather than requiring a click.
We also need to figure out some strategy (or documentation?) for when there are multiple pointers. Dispatching a separate input event for each pointer means they will compete to set the value. So either context.dispatchValue could do some debouncing, or the pointer transforms could coordinate with each other to avoid competition (like the coordination they do for rendering using requestAnimationFrame). Probably easiest if context.dispatchValue handled it.
mbostock
force-pushed
the
fil/pointer-dataflow
branch
from
b020568 to
fbcb797
Compare
mbostock
approved these changes
May 24, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* closes observablehq#1628 * dispatch on render * textarea * “debounce” --------- Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1628
todo:
demo: https://observablehq.com/@observablehq/plot-dispatchvalue-1630